Fixed #25745 -- Promoted RuntimeWarnings to errors in the test suite. #5652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This patch focuses on being non-invasive (for the backport to 1.8) but the schema tests would definitely benefit from a refactoring. I spent way more time than expected trying to figure out which bits to flip. |
| @@ -417,15 +421,21 @@ class Child(models.Model): | |||
| related_name='children', | |||
| ) | |||
|
|
|||
| class Meta: | |||
| apps = apps = test_apps | |||
|
@timgraham what should be done in regard to tests that make sure |
|
Yes, you can probably make them use |
charettes
force-pushed
the
ticket-25745-runtimewaring-errors
branch
from
174b001
to
9193a3c
Compare
|
Should be easy to backport if required. |
charettes
changed the title
charettes
force-pushed
the
ticket-25745-runtimewaring-errors
branch
2 times, most recently
from
2397c1e
to
580bbfb
Compare
|
Comments addressed. |
|
I'll merge tomorrow if you don't beat me to it. |
charettes
force-pushed
the
ticket-25745-runtimewaring-errors
branch
from
580bbfb
to
1c5f4e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.