Fixed #25349 - ModelForm bug that occurs when saving None value to a ForeignKey with null=True, blank=False and required=False. #5658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -193,14 +193,7 @@ def __set__(self, instance, value): | |||
| - ``instance`` is the ``child`` instance | |||
| - ``value`` in the ``parent`` instance on the right of the equal sign | |||
| """ | |||
| # If null=True, we can assign null here, but otherwise the value needs | |||
| # to be an instance of the related class. | |||
| if value is None and self.field.null is False: | |||
There was a problem hiding this comment.
I don't think removing this check is the right thing to do.
There was a problem hiding this comment.
I described this change in a more detailed way here:
There was a problem hiding this comment.
Thanks for the explanation. I raised it on the mailing list and there is consensus to remove it. I think it should be done as a separate ticket for clarity (also needs to be documented). Are you able to do it? Here's the ticket: https://code.djangoproject.com/ticket/26179
a ForeignKey with null=True, blank=False and required=False. The solution allows to assign None value to ForeignKey model fields with null=False. Assignment doesn't complain immediately. The validation is deferred to calling save() or full_clean() methods. As a side effect this commit fixes the issue for simple model forms with regular fields set in model to blank=False and in form to required=False. Refs django#13776, django#7551, django#9649, django#6886.
|
Ready for a rebase after 04e13c8 |
|
updated and merged in 375e1cf, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://code.djangoproject.com/ticket/25349