Fixed #25825 --- Implemented __ne__ for template Origin #5736
Conversation
| @@ -151,6 +151,9 @@ def __eq__(self, other): | |||
| self.loader == other.loader | |||
| ) | |||
|
|
|||
| def __ne__(self, other): | |||
There was a problem hiding this comment.
This method is only necessary on Python 2, no?
There was a problem hiding this comment.
Then we could slap an if six.PY2 around it, what do you think? That way we'll know to remove it when we drop Python 2 support.
There was a problem hiding this comment.
I personally don't think that's necessary. A grep for ne and similar Python 2 methods on the entire Django codebase will find this at that time in the future. But if you want to add it I'm fine with it :)
There was a problem hiding this comment.
You're right. We don't have if six.PY2 for __ne__ methods anywhere else so let's keep it consistent.
There was a problem hiding this comment.
FWIW I made sure we don't forget to remove these methods when we drop support for Python 2.
|
merged in c6ea4ed, thanks! |
https://code.djangoproject.com/ticket/25825