Fixed #26034 -- Fixed incorrect index handling on PostgreSQL on Char/TextField with unique=True and db_index=True. #5947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -111,13 +111,13 @@ def _alter_field(self, model, old_field, new_field, old_type, new_type, | |||
| new_db_params, strict, | |||
| ) | |||
| # Added an index? Create any PostgreSQL-specific indexes. | |||
| if ((not old_field.db_index and new_field.db_index) or (not old_field.unique and new_field.unique)): | |||
| if not old_field.db_index and not old_field.unique and (new_field.db_index or new_field.unique): | |||
There was a problem hiding this comment.
I'm curious as to why we're even checking unique.
Does not old_field.db_index and new_field.db_index works?
There was a problem hiding this comment.
Oh are we creating the _like indexes even when unique=True? I wasn't expecting that.
|
It would be great if you actually inspected the index details to make sure the correct ones are created. |
|
As you noted, I think there are other bugs here, but the one in the ticket should be fixed. |
|
Looking at the index name should be good enough, LGTM. |
…TextField with unique=True and db_index=True. Thanks Simon Charette for review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://code.djangoproject.com/ticket/26034