Fixed #26263 -- Deprecated Context.has_key(). #6066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aaugustin, @prestontimmons any opinion on this? |
|
I'm neutral on this change. If we deprecate it, I do like that it lines up with the deprecation of Python 2 support. |
|
+1 on making this cleanup. Considering that:
I'm in favor of implementing a deprecation path. It doesn't look onerous. |
timgraham
force-pushed
the
has-key-context
branch
from
09773f8
to
e595987
Compare
timgraham
changed the title
| self.assertEqual(a.has_key('a'), True) | ||
| self.assertEqual(a.has_key('b'), False) | ||
| self.assertEqual(b.has_key('a'), True) | ||
| self.assertEqual(b.has_key('b'), False) |
There was a problem hiding this comment.
Patch looks good. Did you purposefully prefer assertEqual over assertTrue/assertFalse here?
There was a problem hiding this comment.
I thought it's safer since assertTrue/False will pass for any truthy/falsey value.
timgraham
force-pushed
the
has-key-context
branch
from
e595987
to
cdbd874
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't seem to be documented, but might need to go through a deprecation anyway? (at least a mention in the release notes would be added)
https://groups.google.com/d/topic/django-developers/QoMsYiBo_80/discussion