Fixed #26196 -- Made sure __in lookups use to_field as default. #6111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to Trac alias hellpain for the report.
| root_constraint.add( | ||
| SubqueryConstraint( | ||
| self.lhs.alias, [self.lhs.target.column], | ||
| [f.get_attname_column()[1] for f in self.lhs.output_field.get_path_info()[0].target_fields], |
There was a problem hiding this comment.
@akaariai I'm really not sure from where I should retrieve the SubqueryConstraint.targets. I see that self.lhs.sources is available when isinstance(self.lhs, MultiColSource) but in this case self.lhs.sources is an empty list.
There was a problem hiding this comment.
I'm going to try to work on Django tomorrow. I'll try to work on this.
charettes
referenced
this pull request
Feb 10, 2016
Previously related fields didn't implement get_lookup, instead related fields were treated specially. This commit removed some of the special handling. In particular, related fields return Lookup instances now, too. Other notable changes in this commit is removal of support for annotations in names_to_path().
|
As I see not all django test are passing, so this PR solves one problem and creates another) |
|
Updated by Anssi in #6117. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to Trac alias hellpain for the report.