Fixed #26381 -- Made UserCreationForm reusable with custom user models that define USERNAME_FIELD. #6315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -82,7 +82,9 @@ class Meta: | |||
|
|
|||
| def __init__(self, *args, **kwargs): | |||
| super(UserCreationForm, self).__init__(*args, **kwargs) | |||
| self.fields['username'].widget.attrs.update({'autofocus': ''}) | |||
| username_field = self.fields.get('username') | |||
There was a problem hiding this comment.
self.fields[self._meta.model.USERNAME_FIELD]? I think it's a mandatory field.
There was a problem hiding this comment.
I was thinking something similar to https://github.com/django/django/blob/master/django/contrib/auth/forms.py#L158, but your suggestion is better. Done, thanks!
I also removed the if branch. Perhaps we could catch the KeyError and raise an exception with a more informed message (e.g. USERNAME_FIELD cannot be found in FooCreationForm.Meta.fields)?
…s that define USERNAME_FIELD.
|
As |
|
merged in efa9539, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://code.djangoproject.com/ticket/26381