Fixed #21734 -- Handled ProtectedError on POST to admin's delete_selected action #6348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akki
changed the title
akki
force-pushed
the
ticket_21734
branch
2 times, most recently
from
4090b61
to
8361776
Compare
| response = self.client.post(reverse('admin:admin_views_question_delete', args=(q.pk,)), {'post': 'yes'}) | ||
| self.assertEqual(Question.objects.count(), 1) | ||
| self.assertContains(response, "would require deleting the following protected related objects") | ||
|
|
||
| # If the protected object is tried to be deleted using the delete_selected action. |
There was a problem hiding this comment.
Please put the test in AdminActionsTest.
| q = Question.objects.create(question='Why?') | ||
| Answer.objects.create(question=q, answer='Because.') | ||
|
|
||
| response = self.client.post(reverse('admin:admin_views_question_changelist'), { |
There was a problem hiding this comment.
I think you could add this to test_model_admin_default_delete_action_protected so you don't have to repeat the setup steps.
|
Done. |
|
merged in a7c813b, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://code.djangoproject.com/ticket/21734
Approach is similar to that used to solve #26235 in 49ac10b.