Fixed #26419 -- Rephrased a sentence in ALLOWED_HOSTS docs. #6357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgraham
changed the title
| serve. This is a security measure to prevent an attacker from poisoning caches | ||
| and triggering password reset emails with links to malicious hosts by submitting | ||
| requests with a fake HTTP ``Host`` header, which is possible even under many | ||
| serve. This is a security measure to prevent HTTP Host header attacks, in which |
There was a problem hiding this comment.
You could add a link to the discussion in docs/topics/security.txt:
:ref:`HTTP Host header attacks <host-headers-virtual-hosting>`
Also, I think a comma isn't needed before "in which".
|
Updated according to @timgraham's comments. The effect of the PR is now basically to remove the confusing wording and replace it with a link to docs/topics/security.txt. |
|
merged in f8b31df, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://code.djangoproject.com/ticket/26419#ticket