note on minified jquery.js and DEBUG mode #640
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
The relevant code is at https://github.com/django/django/blob/master/django/contrib/admin/options.py#L401 by the way. |
| Django provides both uncompressed and 'minified' versions of jQuery, as | ||
| ``jquery.js`` and ``jquery.min.js`` respectively. | ||
|
|
||
| The ``BaseModelAdmin`` superclass has a ``media`` property that returns a list |
There was a problem hiding this comment.
I'd like to edit this paragraph slightly, does this look ok:
``ModelAdmin`` and ``InlineModelAdmin`` have a ``media`` property that returns
a list of ``Media`` objects which store paths to the JavaScript files for the
forms and/or formsets. If :setting:`DEBUG` is ``True`` it will return the
uncompressed versions of various JavaScript files, including ``jquery.js``; if
not, it will return the 'minified' versions.
There was a problem hiding this comment.
It looks fine; perhaps a comma after list of Media objects, but more importantly it's more accurate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#639 is more complicated than I first thought, so I have extracted one of the issues from it for this pull request, which I think will be simpler to deal with.