Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #26479 -- Added 'is not' operator to the if tag #6436

Closed
wants to merge 2 commits into from

Conversation

alasdairnicol
Copy link
Contributor

No description provided.

@@ -515,15 +516,6 @@ of how ``x in y`` will be interpreted::

Not contained within. This is the negation of the ``in`` operator.

The comparison operators cannot be 'chained' like in Python or in mathematical
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved this to the bottom of the comparison operators section, because it seemed odd to have it between not in and is. Do you think we should put it in a Note box to make it more visible?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'd use an admonition box with the title "Comparison operators cannot be chained" (separate commit for that move)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it probably makes sense to put it as a paragraph after "if` tags may also use..." before the list of all the operators. In that case, an admonition box probably isn't needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've moved it above the list of operators as suggested, and made the change as a separate commit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another option would be to move it to the end of the complex expressions section.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@alasdairnicol alasdairnicol force-pushed the ticket_26479 branch 2 times, most recently from 1bc5cbc to a3f55d8 Compare April 9, 2016 15:50
@timgraham
Copy link
Member

merged in c10db4b and c16b9dd, thanks!

@timgraham timgraham closed this Apr 9, 2016
@alasdairnicol alasdairnicol deleted the ticket_26479 branch April 9, 2016 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants