Fixed #26729 -- Allowed overriding the label of a tabular inline form field

[czpython]

https://code.djangoproject.com/ticket/26729

[charettes]

Neat trick.

[timgraham]

Could you try to reuse an existing set of models? We try to avoid new models unless absolutely necessary since they slow the test suite.

Also, if it's possible to write the assertion by accessing the appropriate object in response.context, that also makes it easier to debug the test in the event of a failure.

[czpython]

@timgraham
You got it. Regarding your second comment, I'm not sure I follow.. what do you mean by "accessing the appropriate object"? The code in question is here

[timgraham]

Something like response.context['inline_admin_formset'].fields if that works.

[czpython]

@timgraham
Sure however it looks a bit implementation specific

response = self.client.get(reverse('admin:admin_inlines_anotherparentmodel_add'))
field = list(response.context['inline_admin_formset'].fields())[0]
self.assertEqual(field['label'], 'new label')

[timgraham]

I think it's an improvement since that gives some idea of where to look in the event of a test breakage. With assertContains, you really don't have much of an idea. I guess if you want to put the assertContains after those other lines, it would be okay too.

[czpython]

@timgraham Thanks for review. I've updated the pr to reuse model and do more explicit test.

[timgraham]

merged in 9c2d5a8, thanks!

I removed the ticket references. For future reference, we typically include them for obscure issues where the additional context of the ticket is helpful in understanding the issue.