Fixed #26785 -- Set BaseSpatialField.empty_strings_allowed to False. #6816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -223,12 +223,9 @@ def test_intersection(self): | |||
| geom = Point(5, 23, srid=4326) | |||
| qs = Country.objects.annotate(inter=functions.Intersection('mpoly', geom)) | |||
| for c in qs: | |||
| if spatialite or mysql: | |||
| # When the intersection is empty, Spatialite and MySQL return None | |||
| if spatialite or mysql or oracle: | |||
There was a problem hiding this comment.
This could be a separate commit or ticket, but could a database feature flag replace the vendor checks?
There was a problem hiding this comment.
Yes, I thought about this, but I'm planning to do some adjacent changes and I think that it would more clear after that what feature flag we need to add.
|
For the commit message, I usually try to describe the issue that's fixed rather than the implementation. |
|
merged in ea46650, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://code.djangoproject.com/ticket/26785