Fixed #26951 -- Fixed AuthenticationForm to work with integer usernames. #6977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charettes
changed the title
| @override_settings(AUTH_USER_MODEL='auth_tests.CustomUserWithIntegerUsername') | ||
| def test_integer_field(self): | ||
| class CustomAuthenticationForm(AuthenticationForm): | ||
| class Meta(UserCreationForm.Meta): |
There was a problem hiding this comment.
UserCreationForm.Meta looks like a typo to me. Perhaps you meant AuthenticationForm.Meta?
|
Updated tests. Thanks, @berkerpeksag! |
| USERNAME_FIELD = 'username' | ||
| REQUIRED_FIELDS = ['username', 'password'] | ||
|
|
||
| def __str__(self): |
There was a problem hiding this comment.
I think __str__ can be omitted here. If it needs to stay, CustomUserWithIntegerUsername should be wrapped by @python_2_unicode_compatible.
Fixed AuthenticationForm bug when USERNAME_FIELD is an IntegerField. Added explicit check for None for `username` and `password` in `django.contrib.auth.forms.AuthenticationForm.clean` method.
|
Updated code style. Thanks, @berkerpeksag! |
|
The test isn't working as a regression test because it passes before the fix is applied. I added one line to fix it: Merged in 975a76a, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://code.djangoproject.com/ticket/26951