Fixed #27068 -- Unified form field initial data retrieval. #7097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -482,6 +482,12 @@ def visible_fields(self): | |||
| """ | |||
| return [field for field in self if not field.is_hidden] | |||
|
|
|||
| def get_initial(self, field_name, field): | |||
There was a problem hiding this comment.
Add docstring? No need to document this method?
There was a problem hiding this comment.
I wonder if get_initial_for_field might make it more readable?
|
Made adjustments based on feedback. Please review. Thanks. |
| @@ -482,6 +482,17 @@ def visible_fields(self): | |||
| """ | |||
| return [field for field in self if not field.is_hidden] | |||
|
|
|||
| def get_initial_for_field(self, field, field_name): | |||
| """ | |||
| Return initial data for field on form. Return the form's initial data | |||
There was a problem hiding this comment.
For the second sentence, maybe: "Use initial data from the form or the field, in that order."
|
Some tests for |
|
Updated text based on feedback and added recommended tests. All additional feedback is welcome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://code.djangoproject.com/ticket/27068