Fixed #27131 -- Passed proper string type to SMTP connection login #7178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -64,7 +68,7 @@ def open(self): | |||
| self.connection.starttls(keyfile=self.ssl_keyfile, certfile=self.ssl_certfile) | |||
| self.connection.ehlo() | |||
| if self.username and self.password: | |||
| self.connection.login(self.username, self.password) | |||
| self.connection.login(force_str(self.username), force_str(self.password)) | |||
There was a problem hiding this comment.
Should we add a comment that no coercion is needed after dropping Python 2?
There was a problem hiding this comment.
I don't think it's useful. All force_str usage will have to be audited at the time, and most of them will indeed disappear.
|
It could be nice to note in the commit message that this fix is only required on Python 2 (as far as I understand). |
|
By the way, could a Django project work around this by declaring their credentials as bytestrings? |
|
I think you are right about the workaround. I still think it's worth committing, as the patch is testing a little bit deeper inside the SMTP connection process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks slavugan@gmail.com for the report.