Removed unneeded no_settings_commands hardcoded list #7315
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failures seem unrelated. |
timgraham
reviewed
Sep 30, 2016
| try: | ||
| connections.close_all() | ||
| except ImproperlyConfigured: | ||
| # Don't moan if connections aren't setup at this point |
There was a problem hiding this comment.
Don't moan -> Ignore
Also, maybe explain under what circumstances that happens?
claudep
force-pushed
the
no_settings_commands
branch
from
fa268e7
to
f9e0fb7
Compare
|
Looks good except that the comment could be wrapped at 79. |
|
Thanks, merged in fc92c6b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.