Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs #18974 -- Deprecated @models.permalink() decorator. #7323

Merged
merged 1 commit into from Oct 4, 2016
Merged

Refs #18974 -- Deprecated @models.permalink() decorator. #7323

merged 1 commit into from Oct 4, 2016

Conversation

timgraham
Copy link
Member

charettes
charettes reviewed Sep 30, 2016
View reviewed changes
tests/model_permalink/models.py
class Guitarist(models.Model):
name = models.CharField(max_length=50)
slug = models.CharField(max_length=50)
with warnings.catch_warnings(record=True):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need record here.

@timgraham timgraham force-pushed the permalink branch 2 times, most recently from d26b21d to 1e2191a Compare September 30, 2016 17:21
@timgraham timgraham merged commit 0083a4c into django:master Oct 4, 2016
@timgraham timgraham deleted the permalink branch October 4, 2016 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charettes charettes charettes left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@timgraham @charettes