Fixed #27218 -- Returned LogEntry instances from log_addition, log_change, log_deletion #7330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgraham
reviewed
Oct 1, 2016
| @@ -163,6 +163,26 @@ def test_logentry_unicode(self): | |||
| log_entry.action_flag = 4 | |||
| self.assertEqual(six.text_type(log_entry), 'LogEntry Object') | |||
|
|
|||
| def test_custom_log_actions(self): | |||
There was a problem hiding this comment.
This file is mostly for unit testing the LogEntry model, so I would limit the tests to LogEntryManager.log_action(). Similarly, could you try to unit test the ModelAdmin methods rather than having complete request/response tests? Maybe in tests/modeladmin.
p.s. when sending or updating a pull request, please also update the ticket as I just did.
francoisfreitag
force-pushed
the
27218/return_LogEntry_instances
branch
4 times, most recently
from
420a3e1
to
950e314
Compare
timgraham
reviewed
Oct 3, 2016
| # custom log actions behaviour #################################### | ||
| def test_custom_log_actions(self): | ||
| class BandAdmin(ModelAdmin): | ||
| def log_addition(self, request, object, message): |
There was a problem hiding this comment.
I think it would be enough to test that the default implementations return the LogEntry. You're indirectly testing it now by calling super() but the custom methods don't seem necessary.
francoisfreitag
force-pushed
the
27218/return_LogEntry_instances
branch
from
950e314
to
b7424f1
Compare
…ange, log_deletion
francoisfreitag
force-pushed
the
27218/return_LogEntry_instances
branch
from
b7424f1
to
4eeed3c
Compare
|
merged in aa9569f, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://code.djangoproject.com/ticket/27218
This change makes it easier to alter a
LogEntryin a customModelAdminsubclass overridinglog_addition,log_changeorlog_deletion.