New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #27439 -- Documented macOS locale configuration for Django tests. #7501
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just need to fix spell-checking.
@@ -326,6 +326,13 @@ You can resolve this on Debian-based systems, for example, by running:: | |||
$ apt-get install locales | |||
$ dpkg-reconfigure locales | |||
|
|||
You can resolve this for macOS systems by configuring your shell's locale:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to add macOS
to https://github.com/django/django/blob/master/docs/spelling_wordlist to for spell-check to pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
macOS is a replacement of Mac OSX as of Sierra.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't actually run into this problem before, but I do tend to run tests within a linux VM these days. Are there any particular tests that fail without these languages exported so we can target specific tests when verifying this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
I don't think the issue is specific to Mac OS. For example, it's mentioned here: https://docs.djangoproject.com/en/1.10/ref/unicode/#files. |
Indeed, it's not specific to macOS. |
I did not verify this, but I suspect that it can also affect Linux (and *BSD?) systems with certain values for IMHO we should document the
|
@alix-, could you update as per the last comment or do you disagree with it? |
@timgraham Updated. |
No description provided.