Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #27439 -- Documented macOS locale configuration for Django tests. #7501

Merged
merged 1 commit into from Dec 20, 2016
Merged

Fixed #27439 -- Documented macOS locale configuration for Django tests. #7501

merged 1 commit into from Dec 20, 2016

Conversation

alixmartineau
Copy link

No description provided.

Copy link
Contributor

@frgtn frgtn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to fix spell-checking.

@@ -326,6 +326,13 @@ You can resolve this on Debian-based systems, for example, by running::
$ apt-get install locales
$ dpkg-reconfigure locales

You can resolve this for macOS systems by configuring your shell's locale::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to add macOS to https://github.com/django/django/blob/master/docs/spelling_wordlist to for spell-check to pass.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

macOS is a replacement of Mac OSX as of Sierra.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't actually run into this problem before, but I do tend to run tests within a linux VM these days. Are there any particular tests that fail without these languages exported so we can target specific tests when verifying this?

Copy link

@hoylemd hoylemd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@timgraham
Copy link
Member

I don't think the issue is specific to Mac OS. For example, it's mentioned here: https://docs.djangoproject.com/en/1.10/ref/unicode/#files.

@alixmartineau
Copy link
Author

Indeed, it's not specific to macOS.
However, on Debian-based systems, it is generally recommended to use dpkg-reconfigure, as already stated in the docs.
On macOS, you don't have this option, so I think it's beneficial to mention LANG and LC_ALL env variables in this "troubleshooting tests" chapter.

@rfleschenberg
Copy link
Contributor

I did not verify this, but I suspect that it can also affect Linux (and *BSD?) systems with certain values for LANG / LC_ALL.

IMHO we should document the export way, because it also works on shells other than bash. In addition to that, maybe add a note like this:

You can add these commands to your shell's startup file (for example, ~/.bashrc) so you don't have to retype them.

@timgraham
Copy link
Member

@alix-, could you update as per the last comment or do you disagree with it?

@alixmartineau
Copy link
Author

alixmartineau commented Dec 19, 2016

@timgraham Updated.

@timgraham timgraham merged commit 0a8c685 into django:master Dec 20, 2016
@alixmartineau alixmartineau deleted the ticket-27439 branch September 13, 2017 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants