Refs #24245 -- Added introspection for database defaults in the oracle backend. #7638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgraham
reviewed
Nov 30, 2016
| SELECT column_name, data_default | ||
| FROM user_tab_cols | ||
| WHERE table_name = UPPER(%s)""", [table_name]) | ||
| columns_default = {line[0]: line[1] if line[1] != 'NULL' else None for line in cursor.fetchall()} |
There was a problem hiding this comment.
Using tuple unpacking such as ... for a, b, ... in cursor.fetchall() rather than indexing should help readability.
| @@ -8,6 +9,8 @@ | |||
| from django.utils.deprecation import RemovedInDjango21Warning | |||
| from django.utils.encoding import force_text | |||
|
|
|||
| FieldInfo = namedtuple('FieldInfo', FieldInfo._fields + ('default',)) | |||
There was a problem hiding this comment.
If all bulit-in backends are adding 'default' now, might as well put it in the the base FieldInfo, I think.
felixxm
force-pushed
the
refs-24245-oracle
branch
from
6921ec6
to
4bc12e2
Compare
|
I updated PR. Thanks for review. |
felixxm
force-pushed
the
refs-24245-oracle
branch
from
4bc12e2
to
3f57898
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket 24245. I added missing introspection for database defaults in the oracle backend.