Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #27579 -- Added aliases for Python 3's assertion names in SimpleTestCase. #7662

Merged
merged 1 commit into from Dec 7, 2016

Conversation

timgraham
Copy link
Member

@timgraham timgraham commented Dec 6, 2016

@timgraham timgraham changed the title Aliased assertCountEqual() in SimpleTestCase. Added aliases for Python 3's assertion names in SimpleTestCase. Dec 6, 2016
@timgraham timgraham force-pushed the alias-count-equal branch 2 times, most recently from 138b860 to 8958abc Compare December 7, 2016 03:15
@timgraham timgraham changed the title Added aliases for Python 3's assertion names in SimpleTestCase. Fixed #27579 -- Added aliases for Python 3's assertion names in SimpleTestCase. Dec 7, 2016
Copy link
Member

@charettes charettes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -51,7 +49,7 @@


@skipUnlessDBFeature("has_spatialrefsys_table")
class SpatialRefSysTest(unittest.TestCase):
class SpatialRefSysTest(TestCase):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose you didn't use SimpleTestCase because the test was performing queries?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, e.g. SpatialRefSys.objects.get(srid=sd['srid']).

@timgraham timgraham merged commit b5f0b34 into django:master Dec 7, 2016
@timgraham timgraham deleted the alias-count-equal branch December 7, 2016 22:42
@aaugustin
Copy link
Member

Smart!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants