Fixed #27648 -- Deprecated (iLmsu) regex groups in url() patterns. #7749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
LilyFoote
reviewed
Dec 27, 2016
| warnings.warn( | ||
| "Using (?%s) in url() patterns is deprecated." % ch, | ||
| RemovedInDjango21Warning | ||
| ) | ||
| # All of these are ignorable. Walk to the end of the | ||
| # group. | ||
| walk_to_end(ch, pattern_iter) |
There was a problem hiding this comment.
Perhaps it would be clearer to repeat this line:
if ch in "iLmsu#":
warnings.warn(
"Using (?%s) in url() patterns is deprecated." % ch,
RemovedInDjango21Warning
)
# All of these are ignorable. Walk to the end of the
# group.
walk_to_end(ch, pattern_iter)
elif ch in "!=<":
# All of these are ignorable. Walk to the end of the
# group.
walk_to_end(ch, pattern_iter)
timgraham
force-pushed
the
deprecate-flags
branch
from
1d57fa2
to
2f179a4
Compare
timgraham
force-pushed
the
deprecate-flags
branch
from
2f179a4
to
8a1cabe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://code.djangoproject.com/ticket/27648