Fixed #27723 -- Passed MultiWidget's attrs argument to widgets constructors to set the input type. #7835
Conversation
|
This is confusing me because you say it's a regression but the tests (at least not all of them) are passing on 1.10. |
|
Now I'm also confused:), maybe I shouldn't used word "regression". In Django 1.10 |
|
I understand now. I left a comment on the ticket about a possible alternate approach as I'm not sure the new behavior of applying |
|
It's a behavior that some of Django 3rd party apps expecting, e.g. django-filters (see test_widgets.py#L139). I think that approach from ticket 5851 is a issue specific for MultiWidget(
widgets=(
Input(attrs={'class': 'big', 'type': 'text'}),
Input(attrs={'class': 'small', 'type': 'date'}),
)
)Now we apply |
| '<input type="number" value="2" name="code_1" />' | ||
| '<input type="text" value="3" name="code_2" />' | ||
| )) | ||
| widget = MyMultiWidget(widgets=(TextInput(attrs), TextInput(attrs)), attrs={'attrs': 'date'}) |
There was a problem hiding this comment.
What happened to {'attrs': 'date'}? On 1.10, the output is '<input attrs="date" name="code_0" type="number" value="1" /><input attrs="date" name="code_1" type="text" value="2" />'.
| TextInput(), | ||
| ), attrs=attrs) | ||
| self.check_html(widget, 'code', ['1', '2', '3'], html=( | ||
| '<input type="number" value="1" name="code_0" />' |
There was a problem hiding this comment.
On 1.10, the output is: '<input type="number" value="1" name="code_0" />' '<input type="number" value="2" name="code_1" />' '<input type="number" value="3" name="code_2" />'.
|
@timgraham Thanks for review. In the second commit I tried to restore correct behavior from 1.10 without passing |
| @@ -17,6 +17,11 @@ def decompress(self, value): | |||
| return ['', ''] | |||
|
|
|||
|
|
|||
| class MyMultiRenderWidget(MultiWidget): | |||
There was a problem hiding this comment.
Is this test applicable to the patch anymore? It doesn't seem to me that overriding attrs with render() is related to what this patch fixes.
There was a problem hiding this comment.
You're right. I removed it.
| @@ -118,6 +123,42 @@ def test_constructor_attrs(self): | |||
| '<input id="bar_1" type="text" class="small" value="lennon" name="name_1" />' | |||
| )) | |||
|
|
|||
| def test_constructor_attrs_with_type(self): | |||
| attrs = {'type': 'number'} | |||
| widget = MyMultiWidget(widgets=( | |||
There was a problem hiding this comment.
Single line looks okay here. Are 3 widgets needed rather than two?
There was a problem hiding this comment.
I used 3 widgets to check that attrs is not changed inside their constructors, but now it's unnecessary.
Ticket 27723.
Regression in b52c730.