Fixed #27709 -- Fixed get_for_models() for proxies with an empty cache. #7842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charettes
force-pushed
the
ticket-27709-proxy-model-contenttypes-cache
branch
from
316cb79
to
0a6863e
Compare
|
Do you think the code is clear enough without any additional comments? |
|
@timgraham I do now that I've spent some time dealing with it but given this issue was in there for so long some extra comments wouldn't hurt. |
charettes
force-pushed
the
ticket-27709-proxy-model-contenttypes-cache
branch
from
0a6863e
to
06fd910
Compare
|
Adding comments made me realize the code had a bug with contenttypes creation. I added an test and fix the issue so I'll proceed with merge once the build goes green. |
charettes
force-pushed
the
ticket-27709-proxy-model-contenttypes-cache
branch
from
06fd910
to
499940b
Compare
timgraham
reviewed
Jan 13, 2017
| self._add_to_cache(self.db, ct) | ||
| for opts in needed_opts: | ||
| # These weren't in the cache, or the DB, create them. | ||
| # These weren't in the cache, or the DB, create them. |
There was a problem hiding this comment.
You could rewrite this as: "Create content types that weren't in the cache or DB."
Thanks Peter Inglesby for the report and tests.
charettes
force-pushed
the
ticket-27709-proxy-model-contenttypes-cache
branch
from
499940b
to
4e48cfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks Peter Inglesby for the report and tests.