Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #27130 -- Allow using the DjangoTemplates engine without config… #7965

Closed
wants to merge 1 commit into from
Closed

Fixed #27130 -- Allow using the DjangoTemplates engine without config… #7965

wants to merge 1 commit into from

Conversation

reficul31
Copy link
Contributor

…uring settings

Copy link
Member

@aaugustin aaugustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix must target django.template.engine.Engine rather than django.template.backends.django.DjangoTemplates.

The former is the template engine itself, which should be usable as a standalone template engine.

The latter is a thin integration layer for configuring the former according to the project settings.

@aaugustin
Copy link
Member

I left a comment on the ticket explaining why I don't think any changes are needed.

@reficul31
Copy link
Contributor Author

I might be wrong but I think this make testing with the templates quicker than with the django.template.engine.Engine. Since most people don't go over the docs, by providing this feature they might be able to test their templates more quickly as by default they know that django.template.backends.django.DjangoTemplates is being used as the default backend for templates. Again I might be wrong.

@aaugustin
Copy link
Member

Closing per ticket.

@aaugustin aaugustin closed this Jan 28, 2017
@reficul31 reficul31 deleted the ticket_27130 branch January 30, 2017 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants