Improved test coverage for django.contrib.sitemaps. #8208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desecho
force-pushed
the
improve_sitemaps_tests
branch
2 times, most recently
from
1a71ee6
to
940674b
Compare
desecho
changed the title
desecho
force-pushed
the
improve_sitemaps_tests
branch
2 times, most recently
from
a7e067f
to
c54c09b
Compare
timgraham
reviewed
Jun 1, 2017
tests/sitemaps_tests/test_http.py
Outdated
| @@ -52,6 +71,18 @@ def test_simple_sitemap_section(self): | |||
| """ % (self.base_url, date.today()) | |||
| self.assertXMLEqual(response.content.decode(), expected_content) | |||
|
|
|||
| def test_simple_sitemap_no_section(self): | |||
| response = self.client.get('/simple/sitemap-simple2.xml') | |||
| self.assertEqual(response.status_code, 404) | |||
There was a problem hiding this comment.
You can check str(response.context['exception'] is '"No sitemap available for section..." to improve these 404 tests.
tests/sitemaps_tests/test_http.py
Outdated
| @@ -27,6 +27,25 @@ def test_simple_sitemap_index(self): | |||
| """ % self.base_url | |||
| self.assertXMLEqual(response.content.decode(), expected_content) | |||
|
|
|||
| def test_simple_sitemap_index_not_callable(self): | |||
| "A simple sitemap index can be rendered" | |||
There was a problem hiding this comment.
this is the same as the previous docstring -- can it be differentiated?
There was a problem hiding this comment.
If this is exactly the same as the above test, was the goal to add a new test or should this be removed for the time being?
There was a problem hiding this comment.
Only the docstring is the same, obviously the test is different.
tests/sitemaps_tests/test_http.py
Outdated
| self.assertXMLEqual(response.content.decode(), expected_content) | ||
|
|
||
| def test_simple_sitemap_index_paged(self): | ||
| response = self.client.get('/simple-paged/index.xml') |
There was a problem hiding this comment.
You don't know what a docstring is? Trying googling "python docstring".
There was a problem hiding this comment.
Sorry, was thinking of something else.
desecho
force-pushed
the
improve_sitemaps_tests
branch
from
c54c09b
to
02a0484
Compare
|
I made the changes. |
timgraham
force-pushed
the
improve_sitemaps_tests
branch
from
02a0484
to
0eefda4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.