Fixed #27975 -- Fixed crash if ModelChoiceField's queryset=None. #8232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbeith
changed the title
This commit fixes a regression in the ability to use `queryset=None` on `ModelChoiceField` and later set the QuerySet in the form's `__init__` method.
|
Merged in 216bb2e, thanks! (For future reference, please send pull requests to master and the committer will backport from there.) |
timgraham
changed the title
|
Got it, thanks Tim. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a regression in the ability to use
queryset=NoneonModelChoiceFieldand later set the QuerySet in the form's__init__method.https://code.djangoproject.com/ticket/27975