Fixed #27655 -- Added some guidelines to the coding style docs. #8284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgraham
changed the title
|
I think this could need some clarification too: with self.assertRaisesMessage(
SomeError,
'very '
'long '
'message.'
):vs. msg = (
'very '
'long '
'message.'
)
with self.assertRaisesMessage(SomeError, msg): |
jschneier
reviewed
Apr 5, 2017
|
|
||
| * Use single quotes for strings, or a double quote if the the string contains a | ||
| single quote. Don't waste time doing unrelated refactoring of existing code | ||
| to confirm to this style. |
adamchainz
reviewed
May 12, 2017
|
|
||
| raise AttributeError( | ||
| "Here is a multine error message " | ||
| "shortened for clarity." |
There was a problem hiding this comment.
this should be single quotes as per the next bullet point 😉
|
This has been open some time now, merge it and create another if any more rules crop up? |
timgraham
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm going to leave this open for a little while and add other things that I came across as I do reviews.
https://code.djangoproject.com/ticket/27655