Fixed #28207 -- Fixed contrib.auth.authenticate() if multiple auth backends don't accept a request. #8505
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The easiest fix would be to just copy the contents of
credentials
at the top of the loop, but I think it is worthwhile breaking out a helper function.IMHO the loop's body is complicated enough to warrant a new function, aligns the Single Responsibility Principle and avoids introducing an arguably ugly dictionary copy.