Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #28260 -- Allowed customizing the test tablespace initial and autoextend size on Oracle. #8581

Merged
merged 1 commit into from Jun 2, 2017

Conversation

felixxm
Copy link
Member

@felixxm felixxm commented Jun 1, 2017

@@ -361,6 +365,11 @@ Miscellaneous
``PASSWORD_RESET_TIMEOUT_DAYS = 3``, password reset tokens are now valid for
72 hours rather than 96 hours.

* The default size of the Oracle test tablespace has increased from 20M to 50M.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single bullet point seems okay: "The default size of the Oracle test tablespace is increased from 20M to 50M and the default autoextend size is increased ..."


Default: ``'50M'``

.. versionchanged:: 2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changed annotations/notes can be omitted. Most users are unlikely to care, I'd guess.

@@ -234,6 +234,10 @@ Tests

* Added threading support to :class:`~django.test.LiveServerTestCase`.

* Added settings that allow customization of test tablespace parameters for
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"allow customizing the test tablespace parameters"

@@ -234,6 +234,10 @@ Tests

* Added threading support to :class:`~django.test.LiveServerTestCase`.

* Added settings that allow customization of test tablespace parameters for
Oracle: :setting:`DATAFILE_SIZE`, :setting:`DATAFILE_TMP_SIZE`,
:setting:`DATAFILE_EXTSIZE`, :setting:`DATAFILE_TMP_EXTSIZE`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

, and


This is an Oracle-specific setting.

The size that the DATAFILE is extended when more space is required.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The amount by which the DATAFILE is extended when more space is required.
(use similar wording for next note also)

@timgraham timgraham changed the title Fixed #28260 -- Allowed customization of test tablespace initial and autoextend size on Oracle. Fixed #28260 -- Allowed customizing the test tablespace initial and autoextend size on Oracle. Jun 2, 2017
…utoextend size on Oracle.

Thanks Tim Graham for the review.
@felixxm
Copy link
Member Author

felixxm commented Jun 2, 2017

@timgraham Thanks for review. I updated docs.

@felixxm felixxm merged commit 516b766 into django:master Jun 2, 2017
@felixxm felixxm deleted the issue-28260 branch June 2, 2017 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants