Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added models validator for REQUIRED_FIELDS not being a list. #862

Closed
wants to merge 2 commits into from
Closed

Added models validator for REQUIRED_FIELDS not being a list. #862

wants to merge 2 commits into from

Conversation

romanalexander
Copy link

I spent some time debugging django-admin.py createsuperuser raising optparse.OptionConflictError. I forgot to make REQUIRED_FIELDS custom user model a list. This validation error should help others avoid my mistake.

@charettes
Copy link
Member

You should open a ticket in trac and link it to this PR. We mainly use PR to review patches.

Concerning the patch, shouldn't tuple be also allowed or even preferred in this case?

@romanalexander
Copy link
Author

Sorry, I had read in the docs that a ticket wasn't necessary if its a small update, and I thought this fell in that case.

I'm sure tuple would also be acceptable, but I was just followed the documentation.

Edit: Ticket submitted to trac here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants