Fixed #22569 -- Allowed ModelAdmin.lookup_allowed() to respect get_list_filter(). #8856
Conversation
DrMeers
force-pushed
the
22569_lookup_allowed
branch
2 times, most recently
from
915459a
to
24f491b
Compare
|
Actually I wonder whether we should just make the |
There was a problem hiding this comment.
I would first document lookup_allowed() (https://code.djangoproject.com/ticket/17985) and then implement a deprecation path for adding the request argument, similar to 487362f, rather than making the backwards incompatible change for existing overrides of lookup_allowed().
docs/releases/2.0.txt
Outdated
| * ``ModelAdmin.lookup_allowed`` now accepts a ``request`` parameter to ensure | ||
| it respects ``get_list_filter``. The parameter is optional to maintain | ||
| backwards compatibility. | ||
| * A new ``ModelAdmin.get_changelist_instance`` method creates new override |
There was a problem hiding this comment.
Other than using this in the new test, I don't see how it's linked to the rest of the PR. I think it should have its own ticket, tests, docs, and PR. That'll help simplify this one.
|
Agreed on both counts, thanks @timgraham |
DrMeers
force-pushed
the
22569_lookup_allowed
branch
from
24f491b
to
ee71b9a
Compare
DrMeers
force-pushed
the
22569_lookup_allowed
branch
from
ee71b9a
to
e30059c
Compare
timgraham
changed the title
|
Simon, do you want to continue this? |
|
Closing due to inactivity. |
|
Sorry @timgraham , I really do want to continue this but am not sure if/when I'll find the time :( |
https://code.djangoproject.com/ticket/22569