Refs #28643 -- Reorganized database functions. #9227
Conversation
felixxm
force-pushed
the
functions-text
branch
from
85ce001
to
1632229
Compare
There was a problem hiding this comment.
It might be worth planning the organization of the docs and code as work on #28643 continues. Is "base.py" moving toward "misc.py"? Should "ref/models/database-functions.html" headers be organized alphabetically or in some other fashion? (currently "Text Functions" is before "Date Functions"). Also, I noticed "Windows functions" (lower case "l" inconsistency in the header).
| Text Functions | ||
| ============== | ||
|
|
||
| .. module:: django.db.models.functions.text |
There was a problem hiding this comment.
I think we shouldn't document the functions in the "text" namespace. Most other references in Django are documented in the convenient import location. Not doing that for functions.datetime was probably a mistake.
felixxm
force-pushed
the
functions-text
branch
from
1632229
to
eabcf85
Compare
felixxm
changed the title
felixxm
force-pushed
the
functions-text
branch
from
eabcf85
to
0888f0f
Compare
|
@timgraham Thanks for suggestions. I totally agree with you. I added plan to the ticket (see comment) and reorganized existing docs and code. |
|
Perhaps the "misc" functions should be documented in their own section rather than at the top of the page at a separate heading level from the categorized functions. I'd make the documentation changes separately so they can be backported to stable/2.0.x, otherwise we're going to have pain backporting any documentation changes to that file in the coming months. |
felixxm
force-pushed
the
functions-text
branch
2 times, most recently
from
a28c9a1
to
f9b9aac
Compare
felixxm
changed the title
|
@timgraham I prepared separate PR with docs changes #9234. |
felixxm
force-pushed
the
functions-text
branch
from
f9b9aac
to
69e0882
Compare
| @@ -0,0 +1,85 @@ | |||
| """ | |||
| Classes that represent database functions. | |||
There was a problem hiding this comment.
"""Database functions that do comparisons or type conversions."""
| Cast, Coalesce, Concat, ConcatPair, Greatest, Least, Length, Lower, Now, | ||
| StrIndex, Substr, Upper, | ||
| ) | ||
| from .comp_conv import Cast, Coalesce, Greatest, Least |
There was a problem hiding this comment.
I think "comparison.py" is fine.
|
|
||
| def as_postgresql(self, compiler, connection): | ||
| # Postgres' CURRENT_TIMESTAMP means "the time at the start of the | ||
| # transaction". We use STATEMENT_TIMESTAMP to be cross-compatible with |
There was a problem hiding this comment.
While moving this, chop "we".
| output_field = fields.DateTimeField() | ||
|
|
||
| def as_postgresql(self, compiler, connection): | ||
| # Postgres' CURRENT_TIMESTAMP means "the time at the start of the |
There was a problem hiding this comment.
"Postgres'" looks odd to me. Use "PostgreSQL's" instead.
| super().__init__(*expressions, **extra) | ||
|
|
||
| def as_oracle(self, compiler, connection): | ||
| # we can't mix TextField (NCLOB) and CharField (NVARCHAR), so convert |
There was a problem hiding this comment.
rewrite without "we": "Oracle prohibits mixing TextField (NCLOB) and CharField (NVARCHAR), so convert all fields to NCLOB when that type is expected."
| function = 'TO_NCLOB' | ||
|
|
||
| expressions = [ | ||
| ToNCLOB(expression) for expression in self.get_source_expressions()] |
felixxm
force-pushed
the
functions-text
branch
2 times, most recently
from
64331de
to
0f6455c
Compare
Thanks Tim Graham for the review.
felixxm
force-pushed
the
functions-text
branch
from
0f6455c
to
f608f82
Compare
No description provided.