New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #28117 -- Added a helpful message in loaddata when psycopg2 can't load a fixture due to NUL(0x00) characters. #9500

Merged
merged 1 commit into from Dec 30, 2017

Conversation

Projects
None yet
3 participants
@srinivasreddy
Contributor

srinivasreddy commented Dec 28, 2017

@timgraham

This comment has been minimized.

Show comment
Hide comment
@timgraham

timgraham Dec 28, 2017

Member

A test is also required.

Member

timgraham commented Dec 28, 2017

A test is also required.

@srinivasreddy

This comment has been minimized.

Show comment
Hide comment
@srinivasreddy
Contributor

srinivasreddy commented Dec 29, 2017

@timgraham done

@timgraham timgraham changed the title from Fixes#28117: ValueError will be raised when an object contains NUL(0x00) chars on Postrgres DB to Fixed #28117 -- Added a helpful message in loaddata when psycopg2 can't load a fixture due to NUL(0x00) characters. Dec 29, 2017

Show outdated Hide outdated tests/fixtures/fixtures/postgres_nul.json
Show outdated Hide outdated tests/fixtures/tests.py
Show outdated Hide outdated tests/fixtures/tests.py
Show outdated Hide outdated tests/fixtures/tests.py
Show outdated Hide outdated tests/fixtures/tests.py
Show outdated Hide outdated tests/fixtures/fixtures/postgres_nul.json
Show outdated Hide outdated django/core/management/commands/loaddata.py
@srinivasreddy

This comment has been minimized.

Show comment
Hide comment
@srinivasreddy
Contributor

srinivasreddy commented Dec 30, 2017

@timgraham Done

Fixed #28117 -- Added a helpful message in loaddata when psycopg2 can…
…'t load a fixture due to NUL characters.
@nkuttler

This comment has been minimized.

Show comment
Hide comment
@nkuttler

nkuttler Dec 30, 2017

@srinivasreddy Thank you for fixing this issue, and thanks to all involved.

nkuttler commented Dec 30, 2017

@srinivasreddy Thank you for fixing this issue, and thanks to all involved.

@timgraham timgraham merged commit 58ec55b into django:master Dec 30, 2017

17 checks passed

docs Build #20672 ended
Details
flake8 Build #20783 ended
Details
isort Build #20786 succeeded in 25 sec
Details
pull-requests-javascript Build #17158 ended
Details
pull-requests-trusty/database=mysql,label=trusty-pr,python=python3.5 Build #16355 ended
Details
pull-requests-trusty/database=mysql,label=trusty-pr,python=python3.6 Build #16355 ended
Details
pull-requests-trusty/database=mysql_gis,label=trusty-pr,python=python3.5 Build #16355 ended
Details
pull-requests-trusty/database=mysql_gis,label=trusty-pr,python=python3.6 Build #16355 ended
Details
pull-requests-trusty/database=postgis,label=trusty-pr,python=python3.5 Build #16355 ended
Details
pull-requests-trusty/database=postgis,label=trusty-pr,python=python3.6 Build #16355 ended
Details
pull-requests-trusty/database=postgres,label=trusty-pr,python=python3.5 Build #16355 ended
Details
pull-requests-trusty/database=postgres,label=trusty-pr,python=python3.6 Build #16355 ended
Details
pull-requests-trusty/database=spatialite,label=trusty-pr,python=python3.5 Build #16355 ended
Details
pull-requests-trusty/database=spatialite,label=trusty-pr,python=python3.6 Build #16355 ended
Details
pull-requests-trusty/database=sqlite3,label=trusty-pr,python=python3.5 Build #16355 ended
Details
pull-requests-trusty/database=sqlite3,label=trusty-pr,python=python3.6 Build #16355 ended
Details
pull-requests-windows/database=sqlite3,label=windows,python=Python36 Build #12646 ended
Details

@srinivasreddy srinivasreddy deleted the srinivasreddy:28117 branch Dec 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment