Fix #20130: regression in {% cache %} template tag. #954

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@bmispelon
Member

bmispelon commented Mar 25, 2013

No description provided.

@funkybob

This comment has been minimized.

Show comment
Hide comment
@funkybob

funkybob Mar 25, 2013

Given the regression was hidden because the str method of a fragment returns its original string token, will this test fail?

Given the regression was hidden because the str method of a fragment returns its original string token, will this test fail?

This comment has been minimized.

Show comment
Hide comment
@bmispelon

bmispelon Mar 26, 2013

Owner

It does because assertEqual doesn't care about the __str__ method (and FilterExpression doesn't implement any custom __eq__ method).

Owner

bmispelon replied Mar 26, 2013

It does because assertEqual doesn't care about the __str__ method (and FilterExpression doesn't implement any custom __eq__ method).

@timgraham

This comment has been minimized.

Show comment
Hide comment
@timgraham

timgraham Mar 30, 2013

Member

merged in 5080311

Member

timgraham commented Mar 30, 2013

merged in 5080311

@timgraham timgraham closed this Mar 30, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment