Refs #20487 -- Added test for querying mixed case fields with common related model. #9594
Conversation
tests/queries/models.py
Outdated
| @@ -449,6 +449,10 @@ def __str__(self): | |||
| return "category item: " + str(self.category) | |||
|
|
|||
|
|
|||
| class MixedCaseCategoryItem(models.Model): | |||
| Category = models.ForeignKey('SimpleCategory', models.CASCADE) | |||
There was a problem hiding this comment.
Add a comment to draw attention to the capital C, or maybe even change the name to something like CaTeGoRy. It's quite easy to miss it as it stands.
There was a problem hiding this comment.
either that or leave the attribute name alone and define a db_column='CaTeGoRy' to put more emphasis on it.
There was a problem hiding this comment.
Actually I think the test with db_column='CaTeGoRy' is a slightly different test, and one we may want to include as well.
There was a problem hiding this comment.
Yes, it's a different case. I added it.
| @@ -1172,6 +1173,17 @@ def test_lookup_constraint_fielderror(self): | |||
| with self.assertRaisesMessage(FieldError, msg): | |||
| Tag.objects.filter(unknown_field__name='generic') | |||
|
|
|||
| def test_common_mixed_case_foreign_keys(self): | |||
There was a problem hiding this comment.
I'd add a docstring along the lines of "verify that a valid query is generated when fields fetched from joined tables include FKs whose names only differ by case"
There was a problem hiding this comment.
The coding guidelines suggest to omit prefixes like "Verify that" since all tests verify things, otherwise the patch looks fine.
There was a problem hiding this comment.
Thanks. I updated the docstring,
felixxm
force-pushed
the
refs-20487
branch
2 times, most recently
from
8ea2f0a
to
5fb5781
Compare
|
@shaib @charettes Thanks for reviews. I updated PR. |
…related model. Thanks Shai Berger for the review.
https://code.djangoproject.com/ticket/20487