Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #29038 -- Removed closing slash from HTML void tags. #9602

Merged
merged 1 commit into from Jan 21, 2018
Merged

Fixed #29038 -- Removed closing slash from HTML void tags. #9602

merged 1 commit into from Jan 21, 2018

Conversation

jdufresne
Copy link
Member

@ngnpope
Copy link
Member

ngnpope commented Jan 19, 2018

I am +1 on this as frankly XHTML has been dead for a long time and I think that XHTML5 is wishful thinking.

This should be mentioned in the backwards incompatibility section of the release notes as this will break things for anyone using XHTML with Django (assuming there is anyone). The changes in templates are easily reversed by overriding them in a project, but the modifications to tags generated in Python code are not.

@jdufresne
Copy link
Member Author

jdufresne commented Jan 19, 2018 •
edited

I'm happy to add to the backwards incompatible section. However, Django is already using HTML5 features that are incompatible with XHTML. For example, boolean attributes for checked and disabled. Understanding that, do you think a backwards incompatibility note is still necessary?

@jdufresne
Copy link
Member Author

jdufresne commented Jan 19, 2018 •
edited

Added a backwards incompatible note. Let me know what you think of the wording. I can easily tweak it if necessary. Thanks.

@ngnpope
Copy link
Member

ngnpope commented Jan 19, 2018

For example boolean attributes for checked and disabled.

Fair point. I grepped the documentation, here are the most relevant bits:

docs/ref/forms/api.txt-* The output uses HTML5 syntax, targeting ``<!DOCTYPE html>``. For example,
docs/ref/forms/api.txt:  it uses boolean attributes such as ``checked`` rather than the XHTML style
docs/ref/forms/api.txt-  of ``checked='checked'``.

docs/ref/forms/widgets.txt-The HTML generated by the built-in widgets uses HTML5 syntax, targeting
docs/ref/forms/widgets.txt-``<!DOCTYPE html>``. For example, it uses boolean attributes such as ``checked``
docs/ref/forms/widgets.txt:rather than the XHTML style of ``checked='checked'``.

docs/releases/1.11.txt-* The ``checked`` and ``selected`` attribute rendered by form widgets now uses
docs/releases/1.11.txt:  HTML5 boolean syntax rather than XHTML's ``checked='checked'`` and
docs/releases/1.11.txt-  ``selected='selected'``.

docs/releases/2.0.txt-* The ``DEFAULT_CONTENT_TYPE`` setting is deprecated. It doesn't interact well
docs/releases/2.0.txt-  well with third-party apps and is obsolete since HTML5 has mostly superseded
docs/releases/2.0.txt:  XHTML.

Based on previous release notes, it feels right to at least make a mention of the incompatibility - what you've added looks fine.

@timgraham timgraham changed the title Fixed #29038 -- Removed solidus from HTML void tags. Fixed #29038 -- Removed closing slash from HTML void tags. Jan 21, 2018
@timgraham timgraham merged commit ff05de7 into django:master Jan 21, 2018
@jdufresne jdufresne deleted the html5-void branch January 21, 2018 13:56
felixxm added a commit to felixxm/django that referenced this pull request Jul 6, 2023
@felixxm
Fixed django#9602 -- Added AdminSite.get_model_admin().
d07fc9b 
This allows retrieving an admin class for the given model class without
using internal attributes.
felixxm added a commit to felixxm/django that referenced this pull request Jul 6, 2023
@felixxm
Fixed django#9602 -- Added AdminSite.get_model_admin().
def5b0a 
This allows retrieving an admin class for the given model class without
using internal attributes.
felixxm added a commit to felixxm/django that referenced this pull request Jul 7, 2023
@felixxm
Fixed django#9602 -- Added AdminSite.get_model_admin().
30c5626 
This allows retrieving an admin class for the given model class without
using internal attributes.
felixxm added a commit that referenced this pull request Jul 7, 2023
@felixxm
Fixed #9602 -- Added AdminSite.get_model_admin().
f64fd47 
This allows retrieving an admin class for the given model class without
using internal attributes.
felixxm added a commit to felixxm/django that referenced this pull request Jul 7, 2023
@felixxm
Refs django#9602 -- Moved AlreadyRegistered/NotRegistered exceptions …
b0ebdab 
…django.contrib.admin.exceptions.
felixxm added a commit to felixxm/django that referenced this pull request Jul 7, 2023
@felixxm
Refs django#9602 -- Moved AlreadyRegistered/NotRegistered exceptions …
c50433a 
…django.contrib.admin.exceptions.
felixxm added a commit that referenced this pull request Jul 7, 2023
@felixxm
Refs #9602 -- Moved AlreadyRegistered/NotRegistered exceptions to dja…
2584783 
…ngo.contrib.admin.exceptions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jdufresne @ngnpope @timgraham