Fixed #29036 -- Change SelectDateWidget's empty value #9632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
django/forms/widgets.py
Outdated
| @@ -1014,7 +1014,8 @@ def format_value(self, value): | |||
| year, month, day = d.year, d.month, d.day | |||
| match = self.date_re.match(value) | |||
| if match: | |||
| year, month, day = [int(val) for val in match.groups()] | |||
| # In case of pseudo-ISO dates, e.g. 2017-0-23, return empty string to match empty option value. | |||
There was a problem hiding this comment.
@ziima I know you didn't change this logic but, is this right?
It looks to me as if we're parsing value into a datetime and then parsing it again using date_re. (Or did I read that wrong?)
Shouldn't we be doing one or the other, and not both?
There was a problem hiding this comment.
I was startled as well, the string is parsed twice. Since this wasn't part of the code which would be subject of the ticket, I left it unchanged.
There was a problem hiding this comment.
@ziima OK That's fine. Thanks.
I created a new ticket for the (query) logic error here. https://code.djangoproject.com/ticket/29089
carltongibson
approved these changes
Jan 30, 2018
timgraham
force-pushed
the
29036-empty-value-select-date-widget
branch
from
a3e6c7d
to
f6c928b
Compare
…f the attribute is added by JavaScript. Thanks Tim Graham for the initial patch.
timgraham
force-pushed
the
29036-empty-value-select-date-widget
branch
from
f6c928b
to
fbc3c29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://code.djangoproject.com/ticket/29036