New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #29248 -- Renamed field-box CSS class to fieldBox #9855
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the ticket:
A note in the "backwards incompatible changes" section of the release notes may be useful as that class has been there since Django 1.0 (7a9b55d).
@carltongibson In which file under |
It'll have to be |
Under the "Miscellaneous" subsection under "Backwards incompatible changes in 2.1", or under the ":mod: |
I've added the note to the "Miscellaneous" subsection. Let me know if it needs to be changed. |
b0dd516
to
84c23af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @faheel.
Looks good.
- I squashed the commits and adjusted the commit message to use the past tense.
- The Miscellaneous section seems fine to me. 🙂
Thanks for the input!
I updated the release note to specify "The admin CSS class" and also to double the backticks there, as single backticks don't have a visible effect in the rendered docs. |
https://code.djangoproject.com/ticket/29248