Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #29248 -- Renamed field-box CSS class to fieldBox #9855

Merged
merged 1 commit into from Apr 5, 2018

Conversation

faheel
Copy link
Contributor

@faheel faheel commented Apr 5, 2018

Copy link
Member

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the ticket:

A note in the "backwards incompatible changes" section of the release notes may be useful as that class has been there since Django 1.0 (7a9b55d).

@faheel
Copy link
Contributor Author

faheel commented Apr 5, 2018

@carltongibson In which file under docs/release/ should I add a note about this change? 2.0.5.txt or 2.1.txt?

@carltongibson
Copy link
Member

It'll have to be 2.1.txt.

@faheel
Copy link
Contributor Author

faheel commented Apr 5, 2018

Under the "Miscellaneous" subsection under "Backwards incompatible changes in 2.1", or under the ":mod:django.contrib.admin" subsection (doesn't already exist)?

@faheel
Copy link
Contributor Author

faheel commented Apr 5, 2018

I've added the note to the "Miscellaneous" subsection. Let me know if it needs to be changed.

Copy link
Member

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @faheel.

Looks good.

  • I squashed the commits and adjusted the commit message to use the past tense.
  • The Miscellaneous section seems fine to me. 🙂

Thanks for the input!

@carltongibson carltongibson changed the title Fixed #29248 - Rename field-box class to fieldBox Fixed #29248 -- Renamed field-box CSS class to fieldBox Apr 5, 2018
@timgraham
Copy link
Member

I updated the release note to specify "The admin CSS class" and also to double the backticks there, as single backticks don't have a visible effect in the rendered docs.

@timgraham timgraham merged commit 5d4d62b into django:master Apr 5, 2018
@faheel faheel deleted the ticket_29248 branch April 5, 2018 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants