Fixed #29358 -- Added a system check to prohibit models with more than one primary key. #9911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgraham
changed the title
There was a problem hiding this comment.
HI @hramezani.
This looks good thanks. Just a couple of comments.
django/db/models/base.py
Outdated
| @@ -1436,6 +1437,19 @@ def _check_property_name_related_field_accessor_clashes(cls): | |||
| ) | |||
| return errors | |||
|
|
|||
| @classmethod | |||
| def _check_primary_fields_clashes(cls): | |||
There was a problem hiding this comment.
I think this is a bit vague. Perhaps _check_single_primary_key.
django/db/models/base.py
Outdated
| @classmethod | ||
| def _check_primary_fields_clashes(cls): | ||
| errors = [] | ||
| if sum([1 for f in cls._meta.local_fields if f.primary_key]) > 1: |
There was a problem hiding this comment.
You can just use a generator, without the [ and ] here:
if sum(1 for f in cls._meta.local_fields if f.primary_key) > 1:
|
The new message should also be added to docs/ref/checks.txt. |
…field(ticket_29358)
|
@carltongibson , @timgraham , thank you for the comments. |
carltongibson
approved these changes
May 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a system check to prohibit models with more than one primary_key field(ticket_29358)