Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tutorial05.txt #9916

Closed
wants to merge 1 commit into from
Closed

Update tutorial05.txt #9916

wants to merge 1 commit into from

Conversation

miksyn
Copy link

@miksyn miksyn commented May 3, 2018

No description provided.

@@ -162,7 +162,7 @@ what we can do in an automated test, so let's turn that into an automated test.

A conventional place for an application's tests is in the application's
``tests.py`` file; the testing system will automatically find tests in any file
whose name begins with ``test``.
whose name begins with ``test`` (function names in ``TestCase`` classes must begin with ``test``).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This paragraph is about finding test files.

That individual test methods must be named test_ may be a point worth making but it would be better in the text following the QuestionModelTests example just below here.

@carltongibson
Copy link
Member

carltongibson commented May 3, 2018

Hi @2miksyn. Thanks for the input.

I think this requirement is already covered slightly lower down, line 231:

What happened is this:
* ``manage.py test polls`` looked for tests in the ``polls`` application
* it found a subclass of the :class:`django.test.TestCase` class
* it created a special database for the purpose of testing
* it looked for test methods - ones whose names begin with ``test``

Does this not cover your case? (What prompted you to suggest this change?)

@timgraham
Copy link
Member

I agree with Carlton, this looks redundant.

@timgraham timgraham closed this May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants