Fix #20211: Document backwards-incompatible change in BoundField.label_tag. #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -519,7 +519,7 @@ def label_tag(self, contents=None, attrs=None): | |||
|
|
|||
| If attrs are given, they're used as HTML attributes on the <label> tag. | |||
| """ | |||
| contents = contents or conditional_escape(self.label) | |||
| contents = contents or self.label | |||
There was a problem hiding this comment.
What about if id_: being False (below). Might the label be marked safe without being escaped?
There was a problem hiding this comment.
Good catch, that's indeed the case.
However, the original version still has an issue if id_ is False, since it will mark anything passed as content safe.
I see two ways to fix this:
-
We can either apply
conditional_escapetocontentsafter this line, but the double-escaping of lazy strings would kick in (#20221). -
Another option would be to add an
elseclause to theif id_:clause and applyconditional_escapethere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.