Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inlined code/literals are difficult to distinguish #221

Closed
manfre opened this issue Dec 17, 2014 · 6 comments
Closed

Inlined code/literals are difficult to distinguish #221

manfre opened this issue Dec 17, 2014 · 6 comments
Labels

Comments

@manfre
Copy link

manfre commented Dec 17, 2014

The inlined code appears to only have a monospace font set and with a font size that is slightly larger than the surrounding text. This makes it difficult to see that it is different than that surrounding text.

Example, on https://docs.djangoproject.com/en/1.7/topics/db/sql/, find "Person.objects.all()".

@timgraham
Copy link
Member

In an earlier iteration of the design, the fonts were very different and it was a bit disruptive in my opinion. In the old design the main text was black and the inline literals were green. Do you think a color change might help here or did you have something else in mind?

@manfre
Copy link
Author

manfre commented Dec 17, 2014

Subtle color changes won't really help make it stand out or multiple word literals be cohesive. Giving them the same background color as .highlight and a little bit of side padding helps a lot.

tt.docutils.literal {
background-color: rgb(248, 248, 248);
padding-left: 2px;
padding-right: 2px;
}

@foresmac
Copy link

I think part of the problem is that Roboto and Inconsolata also have glyph shapes and metrics that are too similar. I'd suggest using the body text from the style guide (Palatino?) instead and use Roboto for callouts, block quotes (maybe), side bars, etc.

@manfre
Copy link
Author

manfre commented Dec 17, 2014

Font choice may be part of the problem, but definitely cannot be the only change to make this readable for everyone.

@foresmac
Copy link

Agreed. (Hence, "...part of the problem...".)

@jezdez
Copy link
Contributor

jezdez commented Dec 22, 2014

Not sure if #263 fixes the problem for you, can anyone try it out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants