Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 404 and 500 pages on docs are missing their header and footer #229

Closed
bmispelon opened this issue Dec 18, 2014 · 3 comments
Closed

The 404 and 500 pages on docs are missing their header and footer #229

bmispelon opened this issue Dec 18, 2014 · 3 comments
Assignees
Labels

Comments

@bmispelon
Copy link
Member

This is caused by this rabbit-hole chain of events:

  • 404.html (and 500.html) inherits from base.html
  • base.html includes footer.html (and header.html)
  • footer.html contains {% url 'homepage' %} which doesn't work on docs.djangoproject.com
  • Somehow (that's probably a bug in Django), that makes the {% include %} render to an empty string
@jezdez jezdez closed this as completed in a78e0d2 Dec 18, 2014
@jezdez
Copy link
Contributor

jezdez commented Dec 18, 2014

Hmm, wait, that doesn't seem to do it. Odd. Needs more investigating.

@jezdez jezdez reopened this Dec 18, 2014
@bmispelon
Copy link
Member Author

You need to hardcode all the calls to {% url ... %} in header.html and footer.html. There are quite a few of them actually.

@jezdez
Copy link
Contributor

jezdez commented Dec 18, 2014

I wonder if it's not time to start using django-hosts for this, as that's one way to handle multi-host Django installations that includes being able to reverse URLs between hosts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants