Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix color contrast in header and footer #1233

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix color contrast in header and footer #1233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fac8a15
define color for header/footer together with background
xi Oct 11, 2022
a2e4f8d
use the same colors for header and footer in light and dark theme
xi Oct 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
54 changes: 0 additions & 54 deletions djangoproject/scss/_dark-mode.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,29 +92,6 @@ html[data-theme="light"],
--white-color: #{$black};
}

body .homepage {
.copy-banner {
background: var(--white-color);
}
}

body .copy-banner {
background: darken($green, 10%);

p,
h1 {
color: $green-very-light;

@include respond-min(768px) {
color: $green-very-light;
}

a {
color: $green-very-light;
}
}
}

body table.django-supported-versions,
body table.django-unsupported-versions {
a {
Expand Down Expand Up @@ -147,10 +124,6 @@ html[data-theme="light"],
/* Firefox 18- */
color: $gray-medium-l10;
}

body [role="contentinfo"] {
background: darken($green, 10%);
}
}

html[data-theme="dark"] {
Expand Down Expand Up @@ -192,29 +165,6 @@ html[data-theme="dark"] {
filter: invert(1);
}

.homepage {
.copy-banner {
background: var(--white-color);
}
}

.copy-banner {
background: darken($green, 10%);

p,
h1 {
color: $green-very-light;

@include respond-min(768px) {
color: $green-very-light;
}

a {
color: $green-very-light;
}
}
}

table.django-supported-versions,
table.django-unsupported-versions {
a {
Expand Down Expand Up @@ -247,10 +197,6 @@ html[data-theme="dark"] {
/* Firefox 18- */
color: $gray-medium-l10;
}

[role="contentinfo"] {
background: darken($green, 10%);
}
}

.img-release {
Expand Down
43 changes: 19 additions & 24 deletions djangoproject/scss/_style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,6 +434,7 @@ blockquote {
// Includes global navigation, logo, and tagline at top of document
@include clearfix;
background: $green-dark;
color: $white;
overflow: hidden;
margin: 0;
padding: 10px 0 6px;
Expand All @@ -448,7 +449,7 @@ blockquote {

.meta {
@include font-size(13);
color: var(--primary);
color: $green-medium;
font-weight: 700;
width: auto;
float: left;
Expand Down Expand Up @@ -491,9 +492,7 @@ blockquote {

.menu-button {
@include font-size(20);
background: $green-dark;
border-radius: 23px;
color: var(--menu);
cursor: pointer;
display: block;
float: right;
Expand All @@ -509,7 +508,7 @@ blockquote {
}

&:active {
color: var(--primary);
color: $green-medium;
}

span {
Expand Down Expand Up @@ -542,8 +541,6 @@ blockquote {
}

[role="navigation"] {
background: $green-dark;

width: 100%;

@include respond-min(768px) {
Expand Down Expand Up @@ -579,18 +576,18 @@ blockquote {
}

&.active a {
color: var(--primary);
color: $green-medium;
}
}

a {
color: var(--menu);
color: inherit;
display: block;
padding: 20px 0px;
text-decoration: none;

&:active, &:hover {
color: var(--secondary-accent);
color: $green-medium;
}

@include respond-min(768px) {
Expand All @@ -604,7 +601,7 @@ blockquote {
color: var(--white-color);

&:active, &:hover {
color: var(--secondary-accent);
color: $green-medium;
}

@include respond-min(768px) {
Expand Down Expand Up @@ -651,7 +648,8 @@ blockquote {
}
.copy-banner {
// Large green callout at the top of the page
background: var(--primary);
background: darken($green, 10%);
color: $white;
padding: 1px 10px;

@include respond-min(768px) {
Expand All @@ -662,7 +660,7 @@ blockquote {
h1 {
@include sans-serif;
@include font-size(24);
color: var(--secondary-accent);
color: inherit;
font-weight: 300;
line-height: 1.3;
padding: 1px 0 6px;
Expand All @@ -677,14 +675,13 @@ blockquote {
@include font-size(32);

margin: .35em 0 .35em;
color: var(--secondary-accent);
padding: 1px 0 6px;

}

a {
font-weight: 300;
color: var(--secondary-accent);
color: inherit;
}

a.cta, .cta {
Expand Down Expand Up @@ -860,7 +857,8 @@ blockquote {
@include clearfix;
@include sans-serif;
position: relative;
background: var(--primary);
background: darken($green, 10%);
color: $white;
clear: both;
margin-top: 0px;

Expand Down Expand Up @@ -904,7 +902,6 @@ blockquote {
h2 {
@include font-size(16);
border-top: 1px solid var(--hairline-color);
color: var(--menu);
font-weight: 700;
margin-top: 20px;
padding: 30px 0 10px;
Expand All @@ -927,7 +924,7 @@ blockquote {
}

a {
color: var(--menu);
color: inherit;
text-decoration: none;

&:hover,
Expand All @@ -940,9 +937,9 @@ blockquote {

.footer {
background: $green-dark;
color: $green-light;
margin-top: 20px;
padding: 10px 0 30px;
color: var(--primary-accent);

.footer-logo {
float: left;
Expand All @@ -958,6 +955,10 @@ blockquote {
margin-top: 20px;
}
}

a {
color: inherit;
}
}

.logo {
Expand Down Expand Up @@ -987,7 +988,6 @@ blockquote {

.thanks {
@include font-size(12);
color: var(--primary-accent);
margin: 0;
padding: 0;
@include respond-min(768px) {
Expand Down Expand Up @@ -1041,7 +1041,6 @@ blockquote {

a.in-kind-donors {
@include font-size(20);
color: var(--primary-accent);
}

a.threespot, a.andrevv {
Expand Down Expand Up @@ -1080,10 +1079,6 @@ blockquote {
padding-top: 30px;
margin: 0;
}

a {
color: var(--primary-accent);
}
}
}

Expand Down