Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix feed aggregator n+1 issue [#1261] #1279

Merged
merged 4 commits into from Nov 30, 2022
Merged

Fix feed aggregator n+1 issue [#1261] #1279

merged 4 commits into from Nov 30, 2022

Conversation

marksweb
Copy link
Contributor

@marksweb marksweb commented Nov 30, 2022 •
edited by carltongibson

Simplifying from the changes in #1274 to address the regression in #1261.

This keeps things simple, using select_related on the feed items query and testing to ensure the queries executed from the community index.

Closes #1261

carltongibson
carltongibson approved these changes Nov 30, 2022
View reviewed changes
Copy link
Member

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely. Thanks @marksweb 🏅

@carltongibson carltongibson merged commit 8456ae5 into django:main Nov 30, 2022
@marksweb marksweb deleted the fix/1261/select-related branch November 30, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carltongibson carltongibson carltongibson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

N+1 queries in aggregator.views.index
2 participants
@marksweb @carltongibson