Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back to top link in documentation #1370

Merged
merged 1 commit into from Jul 13, 2023
Merged

Add back to top link in documentation #1370

merged 1 commit into from Jul 13, 2023

Conversation

HanaPoulpe
Copy link
Contributor

@HanaPoulpe HanaPoulpe commented Jun 1, 2023 •
edited

Issue: #203

image

@sabderemane sabderemane requested a review from a team June 1, 2023 15:48
@HanaPoulpe HanaPoulpe force-pushed the doc/accessibility/add-backtotop/203 branch from d3be8f5 to 7b8b448 Compare June 1, 2023 15:53
knyghty
knyghty approved these changes Jun 2, 2023
View reviewed changes
Copy link
Member

@knyghty knyghty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! 🚀

@HanaPoulpe HanaPoulpe force-pushed the doc/accessibility/add-backtotop/203 branch from 7b8b448 to 764b41e Compare June 2, 2023 12:38
@HanaPoulpe HanaPoulpe requested a review from knyghty June 2, 2023 12:39
@sabderemane
Copy link
Sponsor Member

@HanaPoulpe can you please check for the merge conflicts?

@HanaPoulpe HanaPoulpe force-pushed the doc/accessibility/add-backtotop/203 branch from 764b41e to 192dcb2 Compare June 14, 2023 19:01
@HanaPoulpe
Copy link
Contributor Author

@HanaPoulpe can you please check for the merge conflicts?

Conflicts solved and pushed, ready for review and merge

sabderemane
sabderemane requested changes Jun 16, 2023
View reviewed changes
Copy link
Sponsor Member

@sabderemane sabderemane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capture d’écran 2023-06-16 à 01 57 45

This might be due to a class or a style missing (I didn't check deeply), but there is a dot from the ul li list appearing, otherwise looks good!

@HanaPoulpe
Copy link
Contributor Author

Capture d’écran 2023-06-16 à 01 57 45 This might be due to a class or a style missing (I didn't check deeply), but there is a dot from the `ul li` list appearing, otherwise looks good!

Nice catch, I'll check on this

@HanaPoulpe
Copy link
Contributor Author

Capture d’écran 2023-06-16 à 01 57 45

This might be due to a class or a style missing (I didn't check deeply), but there is a dot from the ul li list appearing, otherwise looks good!

I've checked on my local and can't replicate the issue, can you confirm the browser you are using? This is a screenshot from Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0

image

Also making sure: did you rebuild css for testing?

sabderemane
sabderemane approved these changes Jul 13, 2023
View reviewed changes
Copy link
Sponsor Member

@sabderemane sabderemane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @HanaPoulpe !

Welcome on board ⛵

@sabderemane sabderemane merged commit 8a1f555 into django:main Jul 13, 2023
2 checks passed
@sabderemane sabderemane mentioned this pull request Sep 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabderemane sabderemane sabderemane approved these changes

@knyghty knyghty Awaiting requested review from knyghty

Assignees
No one assigned
Labels
DjangoCon 🦄
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HanaPoulpe @sabderemane @knyghty