Fixed doc_test_fixtures.json. #1486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmispelon
force-pushed
the
broken-test-fixture
branch
from
20d8a17
to
c18de11
Compare
The broken fixture was hidden by the cache not being reset between tests. This meant that some tests would fail when run in isolation, but pass when run as part of the whole suite (because previous tests would warm up the cache).
bmispelon
force-pushed
the
broken-test-fixture
branch
from
c18de11
to
03692f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this by running only the tests for
docs:python manage.py test docs.This PR fixes the fixture but also changes the
dev.pysettings to use aDummyCachewhich would catch these kinds of errors in the future (at the cost of slightly worse performance for local development, which I think is acceptable).Because the cache is not being used anymore during the tests, I've had to adjust two tests that were counting queries.