Add django-dev-dashboard as an app #313
Conversation
|
Nice work! One thing I noticed is that it doesn't use the bower setup for the jquery plugin. Any specific reason? |
| doc = model_to_dict(metric) | ||
| doc['data'] = metric.gather_data(since=d) | ||
|
|
||
| return http.HttpResponse( |
There was a problem hiding this comment.
This could use the new JSONResponse class
Only because I haven't found a good way to build it yet, bower clones the gitrepo without minified versions or a concatenated version. It could probably be done in the Makefile? |
|
@relekang Nicely done! The Makefile approach is good enough but we're serving the files with gzip so there is really not much sense in minifying the files (or at least very little). I don't mind having the make task around, since we definitely have inconsistency with some of the other dependencies, so maybe we can revisit this whole minifying business at a later in a different branch/PR. |
|
|
||
| urlpatterns = patterns( | ||
| '', | ||
| url('^$', 'dashboard.views.index', name="dashboard-index"), |
|
I'm gonna take care of setting up the cronjob for running the update_metric command hourly |
|
Thanks for the input |
relekang
force-pushed
the
djddashboard
branch
from
1c4364d
to
8f8b3bc
Compare
|
@jezdez I added some tests |
relekang
force-pushed
the
djddashboard
branch
from
8f8b3bc
to
ca9fe08
Compare
|
Sorry that this has gotten a bit on the backburner, we've been working on a fundraising page in the past week but launched today. Gonna try getting this properly reviewed again and pushed as soon as possible. Thank you for your patience, @relekang! |
|
I understand, thank you for letting me now :) I'll try to keep this up to date with master. |
relekang
force-pushed
the
djddashboard
branch
from
ca9fe08
to
c71ee49
Compare
It uses the code from the django/django-dev-dashboard with some design changes, new tests, translation marks and new migrations. It is added under the host dashboard.djangoproject.com.
relekang
force-pushed
the
djddashboard
branch
from
c71ee49
to
b452ae3
Compare
|
I've made some minor updates (e.g. use requests-mock instead of rmoq) and merged master in #363. |
It uses the code from the django/django-dev-dashboard with some design changes and new migrations. It is added under the host dashboard.djangoproject.com.
There is still some work needed to be done, but I opened this in hope of getting som feedback.
Closes #309
Todo: